Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: coverage threshold #1356

Merged
merged 11 commits into from
Sep 28, 2024
Merged

chore: coverage threshold #1356

merged 11 commits into from
Sep 28, 2024

Conversation

freemanzMrojo
Copy link
Member

@freemanzMrojo freemanzMrojo commented Sep 27, 2024

Description

Set coverage threshold for all the packages. network and hardhat-plugin have a condition since the coverage is also collected from integration tests via yarn test instead of yarn test:unit.

Example of pipeline with error because did not meet the coverage threshold.

Some tests have been commented out, to be addressed via #1357 (details on why it has been done are also there).

Type of change

  • Improvement so we prevent decreasing coverage.

How Has This Been Tested?

Tested locally and via pipeline

Test Configuration:

  • Node.js Version: 20.17.0
  • Yarn Version: 1.22.19

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@freemanzMrojo freemanzMrojo marked this pull request as ready for review September 27, 2024 14:32
@freemanzMrojo freemanzMrojo requested a review from a team as a code owner September 27, 2024 14:32
Copy link

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 97%
97.74% (4198/4295) 95.72% (1365/1426) 96.94% (857/884)
Title Tests Skipped Failures Errors Time
core 764 0 💤 0 ❌ 0 🔥 1m 55s ⏱️
network 675 0 💤 0 ❌ 0 🔥 4m 37s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 17.874s ⏱️

@freemanzMrojo freemanzMrojo merged commit a09df9b into main Sep 28, 2024
12 checks passed
@freemanzMrojo freemanzMrojo deleted the chore/coverage-threshold branch September 28, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants